markusthoemmes commented on a change in pull request #2968: add additional
metrics and logs
URL:
https://github.com/apache/incubator-openwhisk/pull/2968#discussion_r154953108
##########
File path:
core/controller/src/main/scala/whisk/core/loadBalancer/LoadBalancerService.scala
##########
@@ -190,13 +190,20 @@ class LoadBalancerService(config: WhiskConfig, instance:
InstanceId, entityStore
// (because say an invoker is down completely, or the connection to the
message bus is disrupted) or when
// the active ack is significantly delayed (possibly dues to long queues
but the subject should not be penalized);
// in this case, if the activation handler is still registered, remove it
and update the books.
- loadBalancerData.putActivation(activationId, {
- actorSystem.scheduler.scheduleOnce(timeout) {
- processCompletion(Left(activationId), transid, forced = true, invoker
= invokerName)
- }
+ loadBalancerData.putActivation(
+ activationId, {
+ actorSystem.scheduler.scheduleOnce(timeout) {
+ processCompletion(Left(activationId), transid, forced = true,
invoker = invokerName)
+ }
- ActivationEntry(activationId, namespaceId, invokerName,
Promise[Either[ActivationId, WhiskActivation]]())
- })
+ if (TransactionId.metricsKamon) {
Review comment:
Why the extra if?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
