markusthoemmes commented on a change in pull request #2974: Add LogStore which
stores to database and file simultaneously.
URL:
https://github.com/apache/incubator-openwhisk/pull/2974#discussion_r154962670
##########
File path:
common/scala/src/main/scala/whisk/core/containerpool/logging/DockerToActivationLogStore.scala
##########
@@ -67,16 +67,17 @@ class DockerLogStore(system: ActorSystem) extends LogStore
{
override def fetchLogs(activation: WhiskActivation): Future[ActivationLogs]
= Future.successful(activation.logs)
override def collectLogs(transid: TransactionId,
+ user: Identity,
+ activation: WhiskActivation,
container: Container,
action: ExecutableWhiskAction):
Future[ActivationLogs] = {
- val possibleErrors = Set(Messages.logFailure,
Messages.truncateLogs(action.limits.logs.asMegaBytes))
-
container
.logs(action.limits.logs.asMegaBytes,
action.exec.sentinelledLogs)(transid)
- .via(DockerLogStore.toFormattedString)
+ .via(DockerToActivationLogStore.toFormattedString)
.runWith(Sink.seq)
.flatMap { seq =>
+ val possibleErrors = Set(Messages.logFailure,
Messages.truncateLogs(action.limits.logs.asMegaBytes))
Review comment:
Can't be, the truncation message is specific to the limit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
