markusthoemmes commented on issue #3072: Enhance kafka message provider
URL: 
https://github.com/apache/incubator-openwhisk/pull/3072#issuecomment-349955038
 
 
   Can you provide tests for the failure scenarios you implemented here?
   
   In general I have the feeling that we're moving into a direction here, which 
should not really be our business. That is: Write a resilient client to talk to 
Kafka/a Kafka cluster. Personally, I don't grasp all the error-cases 
implemented here and neither do I know if the code is complete in it's error 
handling.
   
   A possibility is to move to a well tested client (like 
https://github.com/cakesolutions/scala-kafka-client or 
https://doc.akka.io/docs/akka-stream-kafka/current/home.html). Quite frankly 
that will be a larger operation than this so I'm a bit unsure on how to 
proceed. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to