sven-lange-last commented on a change in pull request #3007: Clean orphaned 
ifstate.veth* files on Ubuntu 14.04
URL: 
https://github.com/apache/incubator-openwhisk/pull/3007#discussion_r155510254
 
 

 ##########
 File path: ansible/roles/invoker/tasks/clean.yml
 ##########
 @@ -38,3 +38,14 @@
     path: "{{ whisk_logs_dir }}/invoker{{ 
groups['invokers'].index(inventory_hostname) }}"
     state: absent
   become: "{{ logs.dir.become }}"
+
+# Workaround for orphaned ifstate.veth* files on Ubuntu 14.04
+# See https://github.com/moby/moby/issues/22513
+# Remove inactive files older than 60 minutes
+- name: "Clean orphaned ifstate.veth* files on Ubuntu 14.04"
+  shell: |
+    ACTIVE_IFACES_REGEXP=$(ip -oneline link show | grep --only-matching 
--extended-regexp 'veth[0-9a-f]+' | tr '\n' '|' | sed -e 's/.$//' | xargs -I 
'{}' /bin/echo '/run/network/ifstate\.({})')
+    find /run/network -regextype posix-egrep \( -not -regex 
${ACTIVE_IFACES_REGEXP} \) -and -name 'ifstate.veth*' -and -mmin +60 -delete
 
 Review comment:
   @csantanapr My solution looks a little different than your proposed 
solution. The current shell commands fail if no active virtual ethernet 
interfaces exist. This can happen if no Docker container is running at the 
moment. But even if no containers are running at the moment, it makes sense to 
clean up orphaned files.
   
   My new proposal simply leaves out the active interface filter for the 
`find`command.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to