rabbah commented on a change in pull request #2968: add additional metrics and
logs
URL:
https://github.com/apache/incubator-openwhisk/pull/2968#discussion_r155583707
##########
File path:
core/controller/src/main/scala/whisk/core/loadBalancer/LoadBalancerService.scala
##########
@@ -186,13 +187,19 @@ class LoadBalancerService(config: WhiskConfig, instance:
InstanceId, entityStore
// in this case, if the activation handler is still registered, remove it
and update the books.
// in case of missing synchronization between n controllers in HA
configuration the invoker queue can be overloaded
// n-1 times and the maximal time for answering with active ack can be n
times the action time (plus some overhead)
- loadBalancerData.putActivation(activationId, {
- actorSystem.scheduler.scheduleOnce(timeout) {
- processCompletion(Left(activationId), transid, forced = true, invoker
= invokerName)
- }
+ loadBalancerData.putActivation(
+ activationId, {
+ actorSystem.scheduler.scheduleOnce(timeout) {
+ processCompletion(Left(activationId), transid, forced = true,
invoker = invokerName)
+ }
- ActivationEntry(activationId, namespaceId, invokerName,
Promise[Either[ActivationId, WhiskActivation]]())
- })
+ transid.mark(
+ this,
+ LoggingMarkers.LOADBALANCER_ACTIVATION_START(namespaceId.toString),
Review comment:
use `asString` instead which is the convention we use throughout.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
