rabbah commented on a change in pull request #3053: Add init time to activation
record.
URL:
https://github.com/apache/incubator-openwhisk/pull/3053#discussion_r155660467
##########
File path: common/scala/src/main/scala/whisk/core/containerpool/Container.scala
##########
@@ -191,6 +191,7 @@ case class RunResult(interval: Interval, response:
Either[ContainerConnectionErr
def ok = response.right.exists(_.ok)
def toBriefString = response.fold(_.toString, _.toString)
}
+
object Interval {
/** An interval starting now with zero duration. */
Review comment:
@markusthoemmes why is zero a `def` not a `val`? did you intend for
start/end to be dynamically changing - i think this might warrant a comment
explaining that we want start to be "now" but the interval to have zero
duration (hence end = start).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
