csantanapr commented on a change in pull request #3077: Enable ssl on the path 
between edge and controllers
URL: 
https://github.com/apache/incubator-openwhisk/pull/3077#discussion_r155757806
 
 

 ##########
 File path: ansible/group_vars/all
 ##########
 @@ -124,6 +127,13 @@ controller:
       seedNodes: "{{ groups['controllers'] | map('extract', hostvars, 
'ansible_host') | list }}"
   # We recommend to enable HA for the controllers only, if bookkeeping data 
are shared too. (localBookkeeping: false)
   ha: "{{ controller_enable_ha | default(True) and groups['controllers'] | 
length > 1 }}"
+  protocol: "{{ controller_protocol | default('https') }}"
 
 Review comment:
   Can we make the default http instead of https? Helps for local development 
environment 
   
   You can pass override to ansible-playbook with -e flag in Travis if you want 
to enable in Travis testing deploy script 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to