dubeejw commented on a change in pull request #2847: Treat action code as 
attachments for created/updated actions
URL: 
https://github.com/apache/incubator-openwhisk/pull/2847#discussion_r143809511
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/entity/WhiskAction.scala
 ##########
 @@ -243,7 +242,7 @@ object WhiskAction extends DocumentFactory[WhiskAction] 
with WhiskEntityQueries[
           val newDoc = doc.copy(exec = exec.attach)
           newDoc.revision(doc.rev)
 
-          val stream = new 
ByteArrayInputStream(Base64.getDecoder().decode(code))
+          val stream = new ByteArrayInputStream(code.getBytes)
 
 Review comment:
   If this change is left in place, existing deployments will need to do a 
database migration in order to convert old Java action byte attachments to 
Base64 encoded attachments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to