tysonnorris commented on a change in pull request #3092: only consider healthy 
invokers when scheduling
URL: 
https://github.com/apache/incubator-openwhisk/pull/3092#discussion_r156158615
 
 

 ##########
 File path: 
core/controller/src/main/scala/whisk/core/loadBalancer/LoadBalancerService.scala
 ##########
 @@ -324,7 +324,9 @@ class LoadBalancerService(config: WhiskConfig, instance: 
InstanceId, entityStore
 
     loadBalancerData.activationCountPerInvoker.flatMap { currentActivations =>
       allInvokers.flatMap { invokers =>
-        val invokersToUse = if (action.exec.pull) blackboxInvokers(invokers) 
else managedInvokers(invokers)
+        val healthyInvokers = invokers.filter(_._2 == Healthy)
+        val invokersToUse =
+          if (action.exec.pull) blackboxInvokers(healthyInvokers) else 
managedInvokers(healthyInvokers)
 
 Review comment:
   currently if you deploy a single invoker, and it is not id 0, it is ignored; 
so while "ordering of invokers" may be important, it will require some way to 
make sure there is also a way to ignore invokers that should not be referenced 
in the scheduling. How should that be done, if not by referencing the healthy 
state?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to