tysonnorris commented on issue #2984: Dynamic LoadBalancer load using SpiLoader URL: https://github.com/apache/incubator-openwhisk/pull/2984#issuecomment-353461099 @rabbah this is useful IFF creating loadbalancers to do significantly different things is tolerable, like elevating container knowledge to the controller to provide, effectively, "invokerless" envs (e.g. mesos/kube/swarm envs don't need the notion of invokers, since they should have a cluster-wide view). The basic summary of changes that this requires is moving ContainerPool to a shared (common/scala) location, and allowing a case for a loadbalancer that is ContainerFactory-aware. So, yes, I'm all for doing this. This PR, I think, "only" creates the SPI, and does not create new impls, unless I'm missing something, which is fine, but I think some of the signatures need to change to isolate some of the SPI interface and more cleanly define what is the interface that loadbalancer defines. Will review in more details, but would like feedback on the above.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
