jonpspri commented on a change in pull request #3100: add remote_redirect mode for openwhisk_cli installation URL: https://github.com/apache/incubator-openwhisk/pull/3100#discussion_r158591351
########## File path: ansible/roles/cli/tasks/deploy.yml ########## @@ -26,3 +27,7 @@ when: cli_installation_mode == "local" - include: download_cli.yml + when: cli_installation_mode != "remote_redirect" Review comment: My gut says this should be `cli_installation_mode == "remote"` because selecting local install is usually because the download is broken for a particular platform. Of course, I'm not sure local is functionally complete in the configuration. But, more to the point, we should separate making the CLI available for download via NGinx from sourcing the binary for /wsk/bin for local use. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
