csantanapr commented on a change in pull request #3133: Subtle changes to
support S390X deployment of OpenWhisk
URL:
https://github.com/apache/incubator-openwhisk/pull/3133#discussion_r159542521
##########
File path: gradle/docker.gradle
##########
@@ -29,6 +44,7 @@ ext {
dockerRetries = project.hasProperty('dockerRetries') ?
dockerRetries.toInteger() : 3
dockerBinary = project.hasProperty('dockerBinary') ? [dockerBinary] :
['docker']
dockerBuildArg = ['build']
+ dockerArch = project.hasProperty('dockerArch') ? dockerArch :
detectDockerArch()
Review comment:
since there is only one arch for now, I would just make is explicit the
parameter s390x as a flag/property
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
