dgrove-oss commented on a change in pull request #3148: Make memory limits as
config variables
URL:
https://github.com/apache/incubator-openwhisk/pull/3148#discussion_r159924292
##########
File path: common/scala/src/main/scala/whisk/core/entity/MemoryLimit.scala
##########
@@ -41,12 +44,14 @@ import whisk.core.entity.size.SizeInt
protected[entity] class MemoryLimit private (val megabytes: Int) extends
AnyVal {}
protected[core] object MemoryLimit extends ArgNormalizer[MemoryLimit] {
- protected[core] val MIN_MEMORY = 128 MB
- protected[core] val MAX_MEMORY = 512 MB
- protected[core] val STD_MEMORY = 256 MB
+ private val memoryConfig =
loadConfigOrThrow[MemoryLimitConfig]("whisk.memorylimit")
Review comment:
If #3150 gets merged first, let's add "whisk.memorylimit" into the
PureConfigKeys singleton.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
