csantanapr commented on a change in pull request #3141: Use timestamps in Java
error and heap filenames
URL:
https://github.com/apache/incubator-openwhisk/pull/3141#discussion_r160187493
##########
File path: ansible/roles/controller/tasks/deploy.yml
##########
@@ -40,7 +40,7 @@
restart_policy: "{{ docker.restart.policy }}"
hostname: "controller{{ groups['controllers'].index(inventory_hostname) }}"
env:
- "JAVA_OPTS": "-Xmx{{ controller.heap }} -XX:+CrashOnOutOfMemoryError
-XX:+UseGCOverheadLimit -XX:ErrorFile=/logs/java_error.log
-XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=/logs"
+ "JAVA_OPTS": "-Xmx{{ controller.heap }} -XX:+CrashOnOutOfMemoryError
-XX:+UseGCOverheadLimit -XX:ErrorFile=/logs/java_error_{{
ansible_date_time.iso8601_basic_short }}.log -XX:+HeapDumpOnOutOfMemoryError
-XX:HeapDumpPath=/logs/java_heap_{{ ansible_date_time.iso8601_basic_short
}}.hprof"
Review comment:
The new filename will only be different with a new deployment from ansible.
Is that your intention with this, would only collect the first crash info
for every new deployment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
