mdeuser commented on a change in pull request #191: Handle namespace API
listing on the client.
URL:
https://github.com/apache/incubator-openwhisk-cli/pull/191#discussion_r160681944
##########
File path: commands/namespace.go
##########
@@ -86,25 +86,28 @@ var namespaceGetCmd = &cobra.Command{
}
}
- namespace, _, err :=
Client.Namespaces.Get(qualifiedName.GetNamespace())
-
- if err != nil {
- whisk.Debug(whisk.DbgError, "Client.Namespaces.Get(%s) error:
%s\n", getClientNamespace(), err)
+ errHandler := func(err error, kind string) error {
+ whisk.Debug(whisk.DbgError, "Client.%s.List(%s) error: %s\n",
getClientNamespace(), kind, err)
Review comment:
the first `%s` in the `Client.%s.List(%s)` should be the entity name (i.e.
Actions, Packages, etc) that matches the actual Client function name - not the
namespace argument.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
