rabbah commented on a change in pull request #3177: Avoid repeated throttle
check for sequences
URL:
https://github.com/apache/incubator-openwhisk/pull/3177#discussion_r161083890
##########
File path: tests/src/test/scala/limits/ThrottleTests.scala
##########
@@ -327,8 +327,12 @@ class NamespaceSpecificThrottleTests
val oneProps = getAdditionalTestSubject("oneSubject")
wskadmin.cli(Seq("limits", "set", oneProps.namespace,
"--invocationsPerMinute", "1", "--firesPerMinute", "1"))
+ // Create a subject where the rate limits are set to 1 for testing sequences
+ val oneSequenceProps = getAdditionalTestSubject("oneSequenceSubject")
Review comment:
do you need an additional test subject vs reusing one `oneProps` subject
above?
fwiw you only need the invocations per minute for the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
