csantanapr commented on a change in pull request #3182: Fixes to Vagrantfile
URL:
https://github.com/apache/incubator-openwhisk/pull/3182#discussion_r161279369
##########
File path: tools/vagrant/Vagrantfile
##########
@@ -159,7 +159,7 @@ $script_end = <<SCRIPT
touch $HOME/.wskprops
chown -R vagrant:vagrant $HOME
# This allows user to see how to configure the wsk cli outside the VM
- wsk property set --apihost ${WHISK_IP} --namespace guest --auth `cat
${ANSIBLE_HOME}/files/auth.guest`
+ wsk property set --apihost http://${WHISK_IP}:10001 --namespace guest --auth
`cat ${ANSIBLE_HOME}/files/auth.guest`
Review comment:
Don't change this, as it doesn't hit the proxy/edge.
some scenarios will not works like `wsk sdk install` or `wsk api`
When you ssh into the Vagrant host `wsk` is setup in the $PATH
https://github.com/apache/incubator-openwhisk/blob/master/tools/vagrant/Vagrantfile#L152-L155
So when you use `wsk` inside the Vagrant `vagrant ssh` there no need to use
`-i`
An alternative to fix self sign cert access, is what
https://github.com/apache/incubator-openwhisk/pull/3182/files#r161274119 I
think means is to configure the host OS in Vagrant to configure the ssl certs
so the https access is trusted by the OS to be use with a hostname and tools
like curl.
But I see as another PR, this PR will I think would be great to take in now
just to fix the Windows problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
