jthomas opened a new pull request #251: WIP: Improve optional parameter support
URL: https://github.com/apache/incubator-openwhisk-catalog/pull/251
 
 
   I've hit a bug where the script doesn't allow optional parameters, even 
though the script supports this.
   
   If the `CATALOG_AUTH_KEY` parameter is missing, the script will extract the 
value from:
   ```
   -CATALOG_AUTH_KEY=${1:-"$OPENWHISK_HOME/ansible/files/auth.whisk.system"}
   ```
   
   However, if I miss this parameter on the command-line, it assumes there are 
only two parameters, not three and fails. If I pass an empty string to force a 
null parameter, this doesn't pass through to the `source 
"$SCRIPTDIR/validateParameter.sh" $1 $2 $3` correctly. 
   
   I made an attempt to fix this by using environment variables for all 
parameters as they are all optional.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to