rabbah commented on a change in pull request #3174: Change log level
dynamically (updated)
URL:
https://github.com/apache/incubator-openwhisk/pull/3174#discussion_r162048789
##########
File path: common/scala/src/main/scala/whisk/common/Logging.scala
##########
@@ -37,7 +37,11 @@ trait Logging {
* @param message Message to write to the log
*/
def debug(from: AnyRef, message: String)(implicit id: TransactionId =
TransactionId.unknown) = {
- emit(DebugLevel, id, from, message)
+ if (id.meta.extraLogging) {
Review comment:
this still feels wrong to me - it presupposes that you're logging at least
at InfoLevel - where the intent is to enable logging, period. So if the log
level is off, this flag generates no additional output. Is that the intent?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
