ddragosd commented on a change in pull request #72: Updated version of PR-15
URL:
https://github.com/apache/incubator-openwhisk-devtools/pull/72#discussion_r162133539
##########
File path: docker-compose/Makefile
##########
@@ -81,30 +83,58 @@ download-cli:
.PHONY: run
-run: print-host check-required-ports setup start-docker-compose init-couchdb
init-whisk-cli
+run: print-host check-required-ports setup start-docker-compose init-couchdb
quick-start-pause init-whisk-cli init-route-mgmt init-whisk-properties
print-host:
echo "host ip address: ${DOCKER_HOST_IP}"
+.PHONY: init-whisk-properties
+init-whisk-properties:
Review comment:
it's interesting to note that copying `whisk.properties` in the
`PROJECT_HOME` folder AND executing ```docker run -d -p 3128:3128
style95/squid:3.5.26-p1```, developers can also execute the tests ( i.e.
`./gradlew testLean` ). Something to keep in mind for an upcoming PR.
@csantanapr has nicely captured the setup as part of
https://github.com/apache/incubator-openwhisk/blob/master/ansible/README.md#docker-for-mac-users
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
