jonpspri commented on issue #184: Create tarball for Nginx container in OpenWhisk as part of release deploy script URL: https://github.com/apache/incubator-openwhisk-cli/pull/184#issuecomment-359259913 @houshengbo @dubeejw I looked at jonpspri#1 and integrated what I could. My PR for gogradle didn't make it into 0.8.1, so I still have to grab that from my fork for the foreseeable future. I did most of the refactoring you proposed, except I don't include clean in the dependencies for anything (1) because it would wipe out content.json just before we need it for the archive, and (2) at least in my old *ix experience, clean was always invoked by the user from the command line. Also, I left the creation of './bin/wsk' in because it's needed by the testing and just generally nice to have. I added comments because it wasn't obvious from the code what was going on. The Travis build timed out here, probably because of some sort of upstream throttling; however, it ran cleanly in my repository. Please take another look at the changed files and lets figure out if we're ready to merge this beast. I see a few things I can do to break it up into 2-5 smaller PRs and reduce the scariness of applying it. If you'd like I can break it down so we can do piecemeal applications with easy rollbacks.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
