paulcastro commented on a change in pull request #1: Swift 4 support
URL:
https://github.com/apache/incubator-openwhisk-runtime-swift/pull/1#discussion_r163058093
##########
File path: tests/dat/actions/sdk/swift4/hello.swift
##########
@@ -0,0 +1,7 @@
+func main(args: [String:Any]) -> [String:Any] {
+ if let name = args["name"] as? String {
+ return [ "greeting" : "Hello \(name)!" ]
+ } else {
+ return [ "greeting" : "Hello stranger!" ]
+ }
+}
Review comment:
Since some of Swift 3 and Swift 4 tests are the same, should we use a base
directory to store common files so we don't keep duplicates? Maybe I'm being
too picky?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
