tysonnorris commented on a change in pull request #3211: implement
ContainerFactory.cpuShare to fix #3110
URL:
https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r163323393
##########
File path:
core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainerFactory.scala
##########
@@ -126,6 +129,13 @@ object DockerContainerFactoryProvider extends
ContainerFactoryProvider {
logging: Logging,
config: WhiskConfig,
instanceId: InstanceId,
- parameters: Map[String, Set[String]]):
ContainerFactory =
- new DockerContainerFactory(config, instanceId, parameters)(actorSystem,
actorSystem.dispatcher, logging)
+ parameters: Map[String, Set[String]]):
ContainerFactory = {
+
+ new DockerContainerFactory(config, instanceId, parameters,
dockerApiFactory)(
+ actorSystem,
+ actorSystem.dispatcher,
+ logging)
+ }
+ def dockerApiFactory(actorSystem: ActorSystem, logging: Logging) =
Review comment:
wasn't sure how else to make it testable - as a mock
https://github.com/apache/incubator-openwhisk/pull/3211/files#diff-16241f60cd0658f397e5c38d57963c95R63
Will take another look to see if I can simplify it a bit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
