rabbah commented on a change in pull request #3142: externalize
runtimesManifestDefault to runtimes.json
URL:
https://github.com/apache/incubator-openwhisk/pull/3142#discussion_r165717568
##########
File path: ansible/group_vars/all
##########
@@ -30,77 +30,9 @@ whisk:
# runtimes: set of language runtime families grouped by language (e.g.,
nodejs, python)
# blackboxes: list of pre-populated docker action images as "name" with
optional "prefix" and "tag"
# bypassPullForLocalImages: optional, if true, allow images with a prefix
that matches {{ docker.image.prefix }}
-# to skip docker pull in invoker even if the image
is not part of the blackboxe set
+# to skip docker pull in invoker even if the image
is not part of the blackbox set
#
-runtimesManifest: "{{ runtimes_manifest | default(runtimesManifestDefault) }}"
-
-runtimesManifestDefault:
- bypassPullForLocalImages: "{{ bypass_pull_for_local_images | default(false)
}}"
Review comment:
@dgrove-oss when you externalized the manifest to its own file we lost this
change/ability to override this setting.
Reported by @krugazor on Slack.
I'll open an issue - one option to restore this ability is to read this
value from pure config rather than the manifest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
