rabbah commented on a change in pull request #3219: Kubernetes ContainerFactoryProvider implementation URL: https://github.com/apache/incubator-openwhisk/pull/3219#discussion_r166353578
########## File path: core/invoker/src/main/scala/whisk/core/containerpool/kubernetes/KubernetesContainer.scala ########## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package whisk.core.containerpool.kubernetes + +import java.time.Instant +import java.util.concurrent.atomic.AtomicReference + +import akka.stream.StreamLimitReachedException +import akka.stream.scaladsl.Framing.FramingException +import akka.stream.scaladsl.{Framing, Source} +import akka.util.ByteString + +import scala.concurrent.ExecutionContext +import scala.concurrent.Future +import scala.concurrent.duration._ +import spray.json._ +import whisk.common.Logging +import whisk.common.TransactionId +import whisk.core.containerpool.Container +import whisk.core.containerpool.WhiskContainerStartupError +import whisk.core.containerpool.ContainerId +import whisk.core.containerpool.ContainerAddress +import whisk.core.containerpool.docker.{CompleteAfterOccurrences, DockerContainer, OccurrencesNotFoundException} +import whisk.core.containerpool.logging.LogLine +import whisk.core.entity.ByteSize +import whisk.core.entity.size._ +import whisk.http.Messages + +object KubernetesContainer { + + /** + * Creates a container running in kubernetes + * + * @param transid transaction creating the container + * @param image image to create the container from + * @param userProvidedImage whether the image is provided by the user + * or is an OpenWhisk provided image + * @param labels labels to set on the container + * @param name optional name for the container + * @return a Future which either completes with a KubernetesContainer or one of two specific failures + */ + def create(transid: TransactionId, + name: String, + image: String, + userProvidedImage: Boolean = false, + memory: ByteSize = 256.MB, + environment: Map[String, String] = Map(), + labels: Map[String, String] = Map()) + (implicit kubernetes: KubernetesApi, + ec: ExecutionContext, + log: Logging): Future[KubernetesContainer] = { + implicit val tid = transid + + val podName = name.replace("_", "-").replaceAll("[()]", "").toLowerCase() + + val environmentArgs = environment.flatMap { + case (key, value) => Seq("--env", s"$key=$value") + }.toSeq + + val labelArgs = labels.map { + case (key, value) => s"$key=$value" + } match { + case Seq() => Seq() + case pairs => Seq("-l") ++ pairs + } + + val args = Seq( + "--generator", + "run-pod/v1", + "--restart", + "Always", + "--limits", + s"memory=${memory.toMB}Mi") ++ environmentArgs ++ labelArgs + + for { + id <- kubernetes.run(podName, image, args).recoverWith { + case _ => Future.failed(WhiskContainerStartupError(s"Failed to run container with image '${image}'.")) Review comment: We recently (@markusthoemmes specifically) changes the content of this message to use ``` val resourceProvisionError = "Failed to provision resources to run the action." ``` since the image name may be mangled internally for some images. Perhaps we should use that here. @markusthoemmes we should may just make that the default so we prevent this in the future from possibly leaking out to activation responses. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
