dubeejw commented on a change in pull request #3254: Do not disable rule when 
it is updated
URL: 
https://github.com/apache/incubator-openwhisk/pull/3254#discussion_r166935522
 
 

 ##########
 File path: core/controller/src/main/scala/whisk/core/controller/Rules.scala
 ##########
 @@ -313,7 +314,7 @@ trait WhiskRulesApi extends WhiskCollectionAPI with 
ReferencedEntities {
             WhiskTrigger.put(entityStore, oldTrigger.removeRule(ruleName))
           }
 
-          val triggerLink = ReducedRule(actionName, Status.INACTIVE)
+          val triggerLink = ReducedRule(actionName, status)
 
 Review comment:
   `create()` calls `update()` in the controller. We would only check the rule 
status during an update.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to