daisy-ycguo commented on issue #716: Some source files are missing Apache license headers URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/716#issuecomment-364309959 @mrutkows As mentioned in the section "WHAT FILES IN AN APACHE RELEASE DO NOT REQUIRE A LICENSE HEADER?" of [Apache release policy document](http://www.apache.org/legal/src-headers.html#faq-exceptions), ``` A file without any degree of creativity in either its literal elements or its structure is not protected by copyright law; therefore, such a file does not require a license header. If in doubt about the extent of the file's creativity, add the license header to the file. Other files may make sense to have no license header. Three examples are: - Short informational text files; for example README, INSTALL files. The expectation is that these files make it obvious which product they relate to. - Test data for which the addition of a source header would cause the tests to fail. - 'Snippet' files that are combined as form a larger file where the larger file would have duplicate licensing headers. PMCs should use their judgement, err on having a source header and contact legal-discuss@ if unsure. ``` So my opinion is to add license headers to all the files created by OpenWhisk contributors, and only exclude few files which are - files copied from third parties or created by tools - JSON data files which don't support annotation - Test data if annotation will break the tests - Few files leading with a dot for configurations Please refer to [.rat-excludes](https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/.rat-excludes). Only below files are excluded from adding license headers. ``` # files copied from third parties or created by tools gradlew gradlew.bat Godeps i18n_resources.go # JSON data file doesn't support annotation .*json # Test data # others .gitignore .rat-excludes ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
