upgle opened a new pull request #3265: Change recently added metric key name. 
(very simple change)
URL: https://github.com/apache/incubator-openwhisk/pull/3265
 
 
   
   This PR is related with #2968
   and thank you for your commit @mhenke1 
   
   Currently our team is using Kamon with openTSDB (not statsd)
   but it is not supports to aggregate values with underscore(_).
   
   i think it is more common to use dot(.)
   As [mhenke1 
said](https://github.com/apache/incubator-openwhisk/pull/2968/files#r155776842),
 Grafana allows to aggregate values on any 'regexable' - sub-string of the 
metric name
   
   and already docker metric key is using dot
   ```scala
   def INVOKER_RUNC_CMD(cmd: String) = LogMarkerToken(invoker, s"runc.$cmd", 
start)
   ```
   
   Most of the metric key names already used is using camelcase, so i changed 
name convention also.
   
   ## before
   ```
   container_start_containerState_namespaceName_actionName
   ```
   
   ## after
   ```
   containerStart.containerState.namespaceName.actionName
   ```
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to