cbickel commented on a change in pull request #3077: Enable ssl on the path
between edge and controllers
URL:
https://github.com/apache/incubator-openwhisk/pull/3077#discussion_r167501744
##########
File path:
core/controller/src/main/scala/whisk/core/controller/Controller.scala
##########
@@ -161,7 +161,7 @@ object Controller {
// a value, and whose values are default values. A null value in the Map
means there is
// no default value specified, so it must appear in the properties file
def requiredProperties =
- Map(WhiskConfig.controllerInstances -> null) ++
+ Map(WhiskConfig.controllerInstances -> null,
WhiskConfig.controllerProtocol -> null) ++
Review comment:
Pure config as well.
But if you really need to keep it in WhiskConfig, it is already in
`RestApiCommons.requiredProperties `. So you don't need to add it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
