mrutkows commented on a change in pull request #738: GH-735 adjusting check for 
github to mainly make sure that github app?

 File path: utils/dependencies_test.go
 @@ -0,0 +1,55 @@
+// +build unit
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package utils
+import (
+       "testing"
+       ""
+func TestLocationIsGithub(t *testing.T) {
+       assert.True(t, LocationIsGithub(""), "Does 
not allow github without a http/https prefix")
+       assert.True(t, LocationIsGithub(""), 
"Does not allow without a http/https prefix")
+       assert.True(t, LocationIsGithub("";), 
"Does not allow github with a http/https prefix")
+       assert.True(t, 
LocationIsGithub("";), "Does not allow with a http/https prefix")
+func TestLocationIsGithub_WithUsernamePassword(t *testing.T) {
+       assert.True(t, 
LocationIsGithub(""), "Does not 
allow username/password and github without a http/https prefix")
 Review comment:
   Perhaps we should return more info from the function like the uname:pwd and 
flag indicating public/private on the result set for the caller to use.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to