ddragosd commented on a change in pull request #97: Added maven archetype for 
Java Action
URL: 
https://github.com/apache/incubator-openwhisk-devtools/pull/97#discussion_r169993093
 
 

 ##########
 File path: java-action-archetype/.mvn/wrapper/MavenWrapperDownloader.java
 ##########
 @@ -0,0 +1,110 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+import java.net.*;
+import java.io.*;
+import java.nio.channels.*;
+import java.util.Properties;
+
+public class MavenWrapperDownloader {
+
+    /**
+     * Default URL to download the maven-wrapper.jar from, if no 'downloadUrl' 
is provided.
+     */
+    private static final String DEFAULT_DOWNLOAD_URL =
+            
"https://repo.maven.apache.org/maven2/io/takari/maven-wrapper/0.4.0/maven-wrapper-0.4.0.jar";;
 
 Review comment:
   Do we still need the `java-action-archetype/.mvn/wrapper/maven-wrapper.jar` 
bellow given that we're also downloading the wrapper here ? Or can we also use 
that one from the wrapper instead of downloading ? What's the benefit of 
downloading here ? A different version ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to