jonpspri commented on a change in pull request #3133: Subtle changes to support 
S390X deployment of OpenWhisk
URL: 
https://github.com/apache/incubator-openwhisk/pull/3133#discussion_r170027693
 
 

 ##########
 File path: core/invoker/Dockerfile.s390x
 ##########
 @@ -0,0 +1,15 @@
+FROM scala
+
+RUN apt-get update \
+ && DEBIAN_FRONTEND="noninteractive" apt-get install -y docker.io \
 
 Review comment:
   @sudswas  My gut says probably not.  I expect the Docker version should 
match the docker version being used to run OpenWhisk, which means locking in on 
a stable version of Docker CE to use.  So we should adjust the s390x and 
ppc64le Dockerfiles to do that.  Does it make sense for us to use the 
templating engine so we can provide the configuration variable externally?  I 
have lots of thoughts and not a clear direction yet.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to