upgle commented on a change in pull request #3343: Support time-series DB using
Kamon Tag, and optional granular metric.
URL:
https://github.com/apache/incubator-openwhisk/pull/3343#discussion_r170420907
##########
File path: common/scala/src/main/scala/whisk/common/Logging.scala
##########
@@ -164,27 +164,44 @@ private object Logging {
if (simpleName.endsWith("$")) simpleName.dropRight(1)
else simpleName
}
-
}
private object Emitter {
val timeFormat =
DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'").withZone(ZoneId.of("UTC"))
}
-case class LogMarkerToken(component: String, action: String, state: String) {
+case class LogMarkerToken(component: String, action: String, state: String,
tags: Option[Map[String, String]] = None) {
Review comment:
@markusthoemmes
I changed the code, but I'm worried also the scaleable issue that occurs
when using a low-capacity and low-performance Kamon-backend that supports tags.
Should we make a granular option again?
What do you think..?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
