csantanapr commented on a change in pull request #3133: Subtle changes to support S390X deployment of OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3133#discussion_r170484933
########## File path: tools/ubuntu-setup/java8.sh ########## @@ -1,9 +1,15 @@ #!/bin/bash set -e set -x - -sudo apt-get install -y software-properties-common -sudo add-apt-repository -y ppa:webupd8team/java -sudo apt-get update -y -echo oracle-java8-installer shared/accepted-oracle-license-v1-1 select true | sudo /usr/bin/debconf-set-selections -sudo apt-get install -y oracle-java8-installer +arch=`uname -m` +if [ $arch == "ppc64le" ] +then + sudo apt-get update -y + sudo apt-get install openjdk-8-jdk -y +else + sudo apt-get install -y software-properties-common + sudo add-apt-repository -y ppa:webupd8team/java + sudo apt-get update -y + echo oracle-java8-installer shared/accepted-oracle-license-v1-1 select true | sudo /usr/bin/debconf-set-selections Review comment: I think is ok to use openjdk here for both and not have a condition, just update java8.sh to do openjdk for all. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
