markusthoemmes commented on a change in pull request #3196: Fixes #3195 -
create config object for docker in the invoker and get ?
URL:
https://github.com/apache/incubator-openwhisk/pull/3196#discussion_r170839390
##########
File path:
core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainer.scala
##########
@@ -261,6 +265,8 @@ class DockerContainer(protected val id: ContainerId,
// FramingException can also mean exceeding the limits, we cannot
decide which case happened so we resort
// to the general error message. This will be the last element of
the stream.
ByteString(LogLine(Instant.now.toString, "stderr",
Messages.logFailure).toJson.compactPrint)
+ case _: RuntimeException =>
+ ByteString(LogLine(Instant.now.toString, "stderr",
"Ouch.").toJson.compactPrint)
Review comment:
Those two need to be removed I reckon?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
