mdeuser commented on a change in pull request #176: Only fetch action code when saving or copying an action URL: https://github.com/apache/incubator-openwhisk-cli/pull/176#discussion_r170914861
########## File path: commands/action.go ########## @@ -35,27 +35,29 @@ import ( ) const ( - MEMORY_LIMIT = 256 - TIMEOUT_LIMIT = 60000 - LOGSIZE_LIMIT = 10 - ACTIVATION_ID = "activationId" - WEB_EXPORT_ANNOT = "web-export" - RAW_HTTP_ANNOT = "raw-http" - FINAL_ANNOT = "final" - NODE_JS_EXT = ".js" - PYTHON_EXT = ".py" - JAVA_EXT = ".jar" - SWIFT_EXT = ".swift" - ZIP_EXT = ".zip" - PHP_EXT = ".php" - NODE_JS = "nodejs" - PYTHON = "python" - JAVA = "java" - SWIFT = "swift" - PHP = "php" - DEFAULT = "default" - BLACKBOX = "blackbox" - SEQUENCE = "sequence" + MEMORY_LIMIT = 256 + TIMEOUT_LIMIT = 60000 + LOGSIZE_LIMIT = 10 + ACTIVATION_ID = "activationId" + WEB_EXPORT_ANNOT = "web-export" + RAW_HTTP_ANNOT = "raw-http" + FINAL_ANNOT = "final" + NODE_JS_EXT = ".js" + PYTHON_EXT = ".py" + JAVA_EXT = ".jar" + SWIFT_EXT = ".swift" + ZIP_EXT = ".zip" + PHP_EXT = ".php" + NODE_JS = "nodejs" + PYTHON = "python" + JAVA = "java" + SWIFT = "swift" + PHP = "php" + DEFAULT = "default" + BLACKBOX = "blackbox" + SEQUENCE = "sequence" + FETCH_CODE = true + DO_NOT_FETCH_CODE = false Review comment: perhaps a separate issue/pr.. but maybe some of these constants in this block are best defined in the incubator-openwhisk-client-go repo since they are more tightly coupled with api(s) defined in that repo. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
