rabbah commented on a change in pull request #3357: Remove usages of replace 
and replaceAll on the hotpath.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3357#discussion_r170959370
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/entity/ActivationId.scala
 ##########
 @@ -42,7 +42,7 @@ import whisk.http.Messages
  */
 protected[whisk] class ActivationId private (private val id: java.util.UUID) 
extends AnyVal {
   def asString = toString
-  override def toString = id.toString.replaceAll("-", "")
+  override def toString = id.toString.filterNot(_ == '-')
 
 Review comment:
   You'll have to remove `AnyVal` and make the activation id not a value to do 
that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to