dgrove-oss commented on a change in pull request #3211: implement
ContainerFactory.cpuShare to fix #3110
URL:
https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r171016731
##########
File path:
core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainerFactory.scala
##########
@@ -67,13 +70,13 @@ class DockerContainerFactory(config: WhiskConfig,
image = image,
userProvidedImage = userProvidedImage,
memory = memory,
- cpuShares = config.invokerCoreShare.toInt,
+ cpuShares = poolConfig.cpuShare,
Review comment:
go ahead and put it in; I will update KubernetesContainerFactory later.
You are right, currently we are only passing in a memory limit in
KubernetesContainerFactory. However, passing in a CPU limit will be small step
beyond the change in #3338 to do pod creation via the kubeRestClient
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
