csantanapr commented on a change in pull request #3358: Update to 
tools/ubuntu-setup to support xenial and later Ubuntu releases
URL: 
https://github.com/apache/incubator-openwhisk/pull/3358#discussion_r171270770
 
 

 ##########
 File path: tools/ubuntu-setup/java8.sh
 ##########
 @@ -2,8 +2,10 @@
 set -e
 set -x
 
-sudo apt-get install -y software-properties-common
-sudo add-apt-repository -y ppa:webupd8team/java
-sudo apt-get update -y
-echo oracle-java8-installer shared/accepted-oracle-license-v1-1 select true | 
sudo /usr/bin/debconf-set-selections
-sudo apt-get install -y oracle-java8-installer
+if [ "$(lsb_release -cs)" == "trusty" ]; then
 
 Review comment:
   Nice to have this consistency of openjdk8 for both ubuntu 14 or above

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to