csantanapr commented on issue #23: Add Codable Support for Swift 4.x
URL: 
https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370027301
 
 
   Thanks @jthomas for the review and starting the work to externalize the 
epilogue in to it's own library/package.
   
   
   >Support @escaping closures to allow users to use with async calls.
   ```
   func _run_main<In: Codable, Out: Codable>(mainFunction: (In, @escaping 
(Out?, Error?) -> Void) -> Void) {
   }
   ```
   This just needs the annotation adding and doesn't affect existing code or 
people who don't use that.
   
   Guess what I have in my TODOs? 
   
   ### TODOS:
   - [x] Finish with the Codable test cases
   - [x] Use `@escaping` instead for the callback
   - [x] Refresh again with latest 4.1 snapshot
   - [ ] With now 4.2 announced 4.1 is stable, so skip/remove 4.0 support only 
do 4.1 for now
   
   
>https://github.com/jthomas/OpenWhiskAction/blob/swift4/Sources/epilogue.swift#L84-L93
   This helps the user understand when there has been problems using the 
Codable API versus something else.
   
   I will add the one for more verbose errors ? 
   - [ ] Improved error handled to give more descriptive messages, e.g.
   
   >Sync method style APIs should probably support throws. This enables uses to 
use normal error handling to surface issues.
   
   I thought about this one, will look into this but probably a different PR 
since it's an improvement to dictionary sync that we have today.
   https://github.com/apache/incubator-openwhisk-runtime-swift/issues/29
   
   Super happy that someone is trying this stuff ? 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to