markusthoemmes commented on a change in pull request #3369: Use pureconfig for 
CouchDbRestStore
URL: 
https://github.com/apache/incubator-openwhisk/pull/3369#discussion_r171985206
 
 

 ##########
 File path: 
tests/src/test/scala/whisk/core/controller/test/ActivationsApiTests.scala
 ##########
 @@ -526,18 +526,33 @@ class ActivationsApiTests extends ControllerTestCommon 
with WhiskActivationsApi
     implicit val materializer = ActorMaterializer()
     val activationStore = SpiLoader
       .get[ArtifactStoreProvider]
-      .makeStore[WhiskEntity](whiskConfig, _.dbActivations)(
-        classTag[WhiskEntity],
-        WhiskEntityJsonFormat,
+      .makeStore[WhiskActivation]()(
+        classTag[WhiskActivation],
+        WhiskActivation.serdes,
         WhiskDocumentReader,
         system,
         logging,
         materializer)
     implicit val tid = transid()
-    val entity = BadEntity(namespace, EntityName(ActivationId().toString))
-    put(activationStore, entity)
 
-    Get(s"$collectionPath/${entity.name}") ~> Route.seal(routes(creds)) ~> 
check {
+    class BadActivation(override val namespace: EntityPath,
 
 Review comment:
   Why are these changes needed in this context?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to