chetanmeh commented on a change in pull request #3369: Use pureconfig for 
CouchDbRestStore
URL: 
https://github.com/apache/incubator-openwhisk/pull/3369#discussion_r172005653
 
 

 ##########
 File path: common/scala/src/main/resources/application.conf
 ##########
 @@ -106,6 +106,23 @@ whisk {
         activations-ddoc = "whisks.v2.1.0"
         activations-filter-ddoc = "whisks-filters.v2.1.0"
     }
+
+    # CouchDB related configuration
 
 Review comment:
   The design docs are used by layers above `ArtifactStore` and hence not 
internal to it. Infact the view names are used for other [custom stores][1] to 
determine how to frame the queries.
   
   So they need to be kept separately 
   
   [1]: 
https://github.com/chetanmeh/openwhisk-mongo/blob/master/common/mongo/src/main/scala/whisk/core/database/mongo/MongoViewMapper.scala

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to