dubeejw commented on a change in pull request #256: perform credentials check
before creating consumer
URL:
https://github.com/apache/incubator-openwhisk-package-kafka/pull/256#discussion_r172403904
##########
File path: provider/service.py
##########
@@ -106,7 +113,7 @@ def run(self):
# running trigger should become disabled
# this should be done regardless of which
worker the document claims to be assigned to
logging.info('[{}] Existing running
trigger should become disabled'.format(change["id"]))
- existingConsumer.disable()
+ existingConsumer.shutdown()
Review comment:
Need to update doc above that mentions that the consumer should be disabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
