markusthoemmes opened a new pull request #3396: Self-generate random strings 
without going through a UUID.
   ## Description
   ActivationIDs are generated via UUID.randomUUID() today. Looking through the 
code of that you'll notice that it only generates a random hexadecimal String, 
delimited with dashes. We then proceed to cut out the dashes to end up at our 
ActivationId format.
   We can straight up jump to generate the String ourselves. This even has the 
added benefit of adding more entropy to that String, because the UUID contains 
some bytes to determine its version (which are fixed bytes).
   ## Related issue and scope
   <!--- Please include a link to a related issue if there is one. -->
   - [ ] I opened an issue to propose and discuss this change (#3395)
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [X] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the 
boxes that apply: -->
   - [X] "Bug fix" (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered 
all aspects of the change you're making. -->
   - [X] I signed an [Apache 
   - [X] I reviewed the [style 
 and followed the recommendations (Travis CI will check :).
   - [X] ~~I added tests to cover my changes.~~ (Not necessary as caught by 
existing tests)
   - [X] ~~My changes require further changes to the documentation.~~
   - [X] I updated the documentation where necessary.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to