rabbah commented on a change in pull request #3391: Add namespace-blacklist to invoker. URL: https://github.com/apache/incubator-openwhisk/pull/3391#discussion_r172623147
########## File path: ansible/files/namespace_throttlings_design_document_for_subjects_db.json ########## @@ -0,0 +1,10 @@ +{ + "_id": "_design/namespaceThrottlings", + "views": { + "blockedNamespaces": { + "map": "function (doc) {\n if (doc._id.indexOf(\"/limits\") >= 0) {\n if (doc.concurrentInvocations === 0 || doc.invocationsPerMinute === 0) {\n var namespace = doc._id.replace(\"/limits\", \"\");\n emit(namespace, 1);\n }\n } else if (doc.subject && doc.namespaces && doc.blocked) {\n doc.namespaces.forEach(function(namespace) {\n emit(namespace.name, 1);\n });\n }\n}", Review comment: is there anyway for the index of `/limits` to be `0`? ie should this be a strictly `> 0` test? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services