pritidesai commented on a change in pull request #765: Update 
deploymentreader.go tests and fix bind logic.
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/765#discussion_r172615337
 
 

 ##########
 File path: deployers/deploymentreader.go
 ##########
 @@ -68,48 +66,62 @@ func (reader *DeploymentReader) BindAssets() error {
        return nil
 }
 
-func (reader *DeploymentReader) bindPackageInputsAndAnnotations() error {
-
+func (reader *DeploymentReader) getPackageMap() map[string]parsers.Package {
 
 Review comment:
   thanks a bunch for refactoring this, creating a common subroutine instead of 
repeating this logic in all functions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to