jonpspri commented on issue #3407: WIP: No longer need to build 'whisk/*' 
runtimes for builtins.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3407#issuecomment-371171374
 
 
   Agreed this is pretty massive.  I'll see what I can do to break it up as it 
leaves WIP; some of the changes can be added now and still test clean.  (And 
yes, I did include one other change as I was working that deserves to be its 
own separate PR.  Too many branches going right now...)
   
   The reason for deleting the actionRuntime directories at the same time as 
changing the manifest behavior was to ensure during testing that the new 
manifest behavior didn't have some leftover dependency on the 'whisk/*' images 
and their being pulled in './gradlew distDocker'.  If we're nervous, we can put 
them back, but as other pieces move, they become unneeded and confusing.  I'd 
definitely advise following up with a second PR not too soon after.
   
   Thanks for pointing out the artifacts from those directories that are worth 
saving.  They can be moved into 'tools' and 'docs' with a little work.  We'll 
leave this PR and notes as WIP to guide the staged implementation as well as an 
opportunity to run Travis over the whole enchilada.  I'd suggest three PR's:
   
   1.  Additional configuration variables and ansible changes that can work 
with the existing codebase.
   2.  The invoker changes to use the 'openwhisk/' prefix for runtimes and 
accept directly-pulled images, including any additional ansible changes needed 
in support.
   3.  Move identified useful artifacts into `tools` and `docs`.  Document 
appropriately.
   4.  Progressively remove standalone 'actionContainer' tests to the 
repositories creating those containers and remove corresponding runtime 
directories.  Disable build of those Docker images.
   5.  Move the useful artifacts from the 'actionRuntimes' and delete the 
remaining actionRuntimes directory tree (and Travis changes to remove from the 
ignores list).
   
   Once all that is done, I can move on to my original goal of converting from 
'distDocker' to 'gradle-docker-plugin' to make multi-architecture builds more 
accessible and less of a maintenance headache.
   
   Sound good @rabbah @markusthoemmes ?  (Meanwhile, back to figuring out why 
Travis is failing, then I'll probably still want a PG to see what I broke in 
Functions.)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to