mrutkows commented on a change in pull request #766: adding support for using 
env. variables in inputs JSON
URL: 
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/766#discussion_r172930016
 
 

 ##########
 File path: tests/dat/manifest_validate_multiline_params.yaml
 ##########
 @@ -32,6 +32,15 @@ packages:
                     param_string_type_and_value_only:
                         type: string
                         value: foo
+                    param_json_type_and_value_only_1:
+                        type: json
+                        value: '{ "name": "Sam", "place": "Shire" }'
+                    param_json_type_and_value_only_2:
+                        type: json
+                        value: { "name": "${USERNAME}", "password": 
"${PASSWORD}" }
+                    param_json_type_and_value_only_3:
+                        type: json
+                        value: { "name": "$${USERNAME}", "password": 
"$${PASSWORD}" }
 
 Review comment:
   Thanks for this.  Did we open an spec/docs issue to document this new syntax 
for string literals (ala Kube, etc.)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to