mrutkows commented on a change in pull request #775: add --name project name
flag
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/775#discussion_r173200458
##########
File path: cmd/root.go
##########
@@ -125,6 +125,7 @@ func init() {
RootCmd.PersistentFlags().StringVarP(&utils.Flags.Key, "key", "k", "",
wski18n.T(wski18n.ID_CMD_FLAG_KEY_FILE))
RootCmd.PersistentFlags().StringVarP(&utils.Flags.Cert, "cert", "c",
"", wski18n.T(wski18n.ID_CMD_FLAG_CERT_FILE))
RootCmd.PersistentFlags().BoolVarP(&utils.Flags.Managed, "managed", "",
false, wski18n.T(wski18n.ID_CMD_FLAG_MANAGED))
+ RootCmd.PersistentFlags().StringVarP(&utils.Flags.Name, "name", "", "",
wski18n.T(wski18n.ID_CMD_FLAG_NAME))
Review comment:
Understand why the functionality is needed, but the flag "name" seems too
generic IMO. I would prefer "project" at min. or better "projectname" (fully
self-explanatory).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
