ddragosd commented on a change in pull request #801: Adding Docker and Native support URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/801#discussion_r174629587
########## File path: tests/dat/manifest_data_compose_actions_for_docker.yaml ########## @@ -0,0 +1,39 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for additional +# information regarding copyright ownership. The ASF licenses this file to you +# under the Apache License, Version 2.0 (the # "License"); you may not use this +# file except in compliance with the License. You may obtain a copy of the License +# at: +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software distributed +# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR +# CONDITIONS OF ANY KIND, either express or implied. See the License for the +# specific language governing permissions and limitations under the License. +# + +packages: + IntegrationTestDocker: + actions: + OpenWhiskSkeleton: + docker: openwhisk/skeleton + OpenWhiskSkeletonWithNative: + native: true + CustomDockerAction1: + function: ../src/integration/docker/actions/exec.zip + docker: openwhisk/skeleton + CustomDockerAction2: + function: ../src/integration/docker/actions/exec.zip + native: true + CustomDockerAction3: + function: ../src/integration/docker/actions/bash + native: true + CustomDockerAction4: + function: ../src/integration/docker/actions/go + native: true + CustomDockerAction5: + function: ../src/integration/docker/actions/go + docker: mydockerhub/myimage Review comment: great 👍 should we assume that custom/private docker registries are supported as well, provided the machine has the credentials needed to connect to that registry ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
